TASK-209191 block global trace while inheriting thread data#12
Open
balupillai wants to merge 2 commits intomainfrom
Open
TASK-209191 block global trace while inheriting thread data#12balupillai wants to merge 2 commits intomainfrom
balupillai wants to merge 2 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent the global tracing GC from running while a thread’s heap/object data is being inherited into another thread, by adding an explicit collector barrier around the inheritance operation.
Changes:
- Add per-OS-thread state lookup in
luaC_inherit_thread. - Block the collector before inheriting a thread’s heap contents and unblock afterward.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches GC/thread synchronization by adding collector blocking around
luaC_inherit_thread, which could introduce or resolve subtle deadlock/timing issues in a highly concurrent, correctness-critical path.Overview
Prevents global tracing/collector activity from interleaving with thread reclamation by blocking the collector during
luaC_inherit_threadwhile it steals objects, updates ownership, and removes the reclaimed heap fromall_heaps.This adds per-thread state retrieval and a
block_collector/unblock_collectorbracket around the critical section to reduce lock contention/races between global trace and thread inheritance.Written by Cursor Bugbot for commit b88bfd0. This will update automatically on new commits. Configure here.